Fix broken dropdowns, prepare v0.5.1 #139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bgentry
added a commit
that referenced
this pull request
Sep 2, 2024
* rely on builtin Listbox positioning + z-index class * re-upgrade headless UI w/ positioning fixes The issue in #138 (fixed by #139) was the result of positioning the listbox using tailwind classes instead of the `Listbox`'s own attrs for positioning. Using the builtin positioning option seems to have fixed this even on the latest version.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bug reported in #138 appears to have been caused by a headless UI upgrade (tailwindlabs/headlessui#3386), and only manifests itself in production builds. Downgrading the dependency to v2.1.1 fixes it.
I also turned on sourcemap builds for prod, because these might make debugging future issues easier and they'll only get loaded when opening the devtools anyway.
Preparing a v0.5.1 release as part of this fix to ship it ASAP.